Skip to content

Autocomplete Implementation #1949

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 18 commits into
base: main
Choose a base branch
from
Open

Autocomplete Implementation #1949

wants to merge 18 commits into from

Conversation

FastestMolasses
Copy link
Member

Description

Adds first iteration of the autocomplete feature.

Related Issues

Checklist

  • I read and understood the contributing guide as well as the code of conduct
  • The issues this PR addresses are related to each other
  • My changes generate no new warnings
  • My code builds and runs on my machine
  • My changes are all related to the related issue above
  • I documented my code

Screenshots

@FastestMolasses FastestMolasses marked this pull request as ready for review December 30, 2024 04:17
@tom-ludwig tom-ludwig added the WIP This is work-in-progress label Feb 27, 2025
@thecoolwinter
Copy link
Collaborator

That last I just pushed should fix build errors. Going to merge once tests are passing and it looks ready to go

@thecoolwinter
Copy link
Collaborator

Looks like there's some bug with either requesting completion items or filtering them. If I have a swift script like:

let string = ""
string.spl

The LSP isn't returning split as an option for completions. Super weird, going to investigate more before merging.

@thecoolwinter
Copy link
Collaborator

thecoolwinter commented Aug 19, 2025

That last commi fixes the issue I mentioned. It turns out that language servers can opt-out of client-side filtering by setting the isIncomplete flag in the item response. This checks for that flag and disables filtering if it's detected.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
WIP This is work-in-progress
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants